[SX128x] Add setDataRate method for LoRa modem #1251
Conversation
|
Thank you for the contribution! The reason this was not implemented in SX128x is that there wasn't a need for it yet. Regarding the ranging modem, I don't think it's needed and/or very useful. The primary use case for abstract interface methods (such as Do you have a specific use-case for ranging modem configuration via |
|
To be honest I haven't even looked into how I would use the ranging
modem yet. Maybe let's just merge this for now, and I can always open
another PR later.
In my current project, RNode Firmware CE, I don't like keeping the
pointer to the base class (I have an array of pointers to each modem
configured for the device), so I simply have one array of PhysicalLayer*
for example. That is why I'd like to use the ranging modem with
`setDataRate`, but thinking about it, this may not be possible anyway
because there's likely other methods I'd need to use which won't be
supported by PhysicalLayer anyway!
…On 24/10/02 09:12am, Jan Gromeš wrote:
Thank you for the contribution! The reason this was not implemented in SX128x is that there wasn't a need for it yet.
Regarding the ranging modem, I don't think it's needed and/or very useful. The primary use case for abstract interface methods (such as `setDataRate`) is to provide cross-module support, mainly for LoRaWAN. Ranging is quite a unique feature of the SX128x series. It is also supported by LR11x0, but not implemented in RadioLib yet.
Do you have a specific use-case for ranging modem configuration via `setDataRate` in mind? If not, then I think this is good to be merged as-is.
--
Reply to this email directly or view it on GitHub:
#1251 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Agreed - merged, than you again!
Depends on what you're trying to do. Ranging is pretty well out-of-scope of the PhysicalLayer class, it is intended to abstract basic stuff, like transmission and reception. |
This PR is tested (on an SX1280 only). It adds the setDataRate function for the LoRa modem of the SX128x series chips, as I was using this modem in a situation where it was preferable to address it through the use of a
PhysicalLayerpointer instead of the base class. I noticed setDataRate wasn't implemented yet, so I implemented it myself.One thing I should mention, would it be a good idea to add support for the ranging modem also? This could always be done at a later date of course, but currently I don't have time to look into it.